Sfd5311/cells index #294
Open
Sfd5311/cells index #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extra complexity is only necessary when multiple distinct DAGs are identical except for a few small parameter values.
I'm not sure about having each 't_maybe_keep_cwlN' operator chained to t_move_data and to t_join, and the BranchPythonOperators almost definitely need some work too.
… each pipeline may or may not run, depending on whether or not there's new datasets in that modality
…que, programatically generating dags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jswelling As we discussed, I parameterized the differences between the DAGs for each modality and generated them in a similar manner to the dags for the rna assays. The task ids should now be globally unique. We now hit ingest api to resolve uuids to abs paths, and use airflow connection hooks for API calls.
I've asserted the existence of a "cells_api_connection" which should map to "https://cells.api.hubmapconsortium.org/api" and a "search_api_connection" which also does not yet exist.